IRC Log Viewer » #firebreath » 2011-11-21

IRC Nick Time (GMT-7) Message
linearray 06:11 dougma: I used that ages ago. It had all the comfort and convenience of 1970s unix.
I'm thinking about using sqlite, since I already need a data store for something else.
taxilian 10:11 good morning
linearray 10:11 mr. taxilian!
taxilian 10:11 mr. linearray!
linearray 10:11 I tried to debug why the log level I set is ignored
and I found no place at all where the Factory is asked for the loglevel
so I did this: https://github.com/linearray/FireBreath/commit/64f16f23bcb8cfd6752aa67b9f28bdc1b9eb76f9
FireBreathBot 10:11 64f16f2 by Max Amanshauser: Fixed log levels. http://goo.gl/mxVZC
taxilian 10:11 huh. I must have never finished that
mind adding a jira issue for it?
linearray 10:11 my understanding of log4cplus is limited, so you may want to check if what I did was correct
not at all
taxilian 10:11 does it seem to work?
linearray 10:11 yes
also with log4cplus disabled
the default log level that log4cplus pulls out of its hat, seems to be Debug
FireBreathBot 10:11 JIRA issue http://jira.firebreath.org/browse/FIREBREATH-146 issue created by amxx
taxilian 10:11 if you want to make a pull request I can probably pull that right in; just rebase the commit message to include that issue #
linearray 10:11 git pull requests
FireBreathBot 10:11 2 open pull requests:
linearray: [FIREBREATH-146]: Fixed log levels. http://goo.gl/BPSAB
linearray: [FIREBREATH-144] Added logging macros that take a single arg... http://goo.gl/LMjo0
taxilian 10:11 could you rewrite the commit message to have the issue# in the commit itself?
(helps keep things organized and findable from jira)
linearray 10:11 ah, the commit message
git pull requests
FireBreathBot 10:11 2 open pull requests:
linearray: [FIREBREATH-146]: Fixed log levels. http://goo.gl/BPSAB
linearray: [FIREBREATH-144] Added logging macros that take a single arg... http://goo.gl/LMjo0
linearray 10:11 better now
taxilian 10:11 much =]
linearray 10:11 btw. -144 should work on all platforms... the internet says starting with VS2005 vararg macros are supported
I just had no opportunity to confirm that
taxilian 10:11 awesome. I still just haven't had time to test it
and I don't consider it a pressing issue
FireBreathBot 10:11 Commit 95b77d0 on master by Max Amanshauser: "[FIREBREATH-146]: Fixed log levels." http://goo.gl/UnSdu
Commit 2440184 on master by Richard Bateman: "Merge pull request #37 from linearray/loglevel
linearray 10:11 do I delete my branch now?
taxilian 10:11 you can
linearray 10:11 or keep it around
alright, heading to a concert, see you later
taxilian 10:11 good luck
emicastro 14:11 if I modified the PluginConfig.cmake, Should be ok with re build the solution?
or I have to run something else?
taxilian 14:11 FireBreathBot: tell emicastro when you change any of your cmake files you need to rerun the prep script
FireBreathBot 14:11 taxilian: I'll pass that on when emicastro is around.
linearray 16:11 slowly, very slowly, I get the hang of git
and this github thing is really smart. Pull requests change when the branch changes.
no wonder everybody wants to give them money!