IRC Log Viewer » #firebreath » 2011-09-28

IRC Nick Time (GMT-7) Message
Chinthu 00:09 This is what I am doing for IE (in ActiveXBrowserHost.cpp)
void ActiveXBrowserHost::Navigate(const char* url) const { IWebBrowser2* pBrowser2; CoCreateInstance(CLSID_InternetExplorer, NULL, CLSCTX_LOCAL_SERVER, IID_IWebBrowser2, (void**)&pBrowser2); if (pBrowser2) { VARIANT vEmpty; VariantInit(&vEmpty); BSTR bstrURL = SysAllocString((BSTR)url); CString s(url); BSTR b = s.AllocSysString(); HRESULT hr = pBrow
sorry about the formatting
dougma 00:09 .pb
FireBreathBot 00:09 When you need to share code, logs, or anything else longer than a couple of lines, use a pastebin. http://fpaste.org, https://pzt.me/, and https://gist.github.com are all good options
dougma 00:09 but why wouldn't you just call document.window.open?
dougma 00:09 and why bother getting the plugin to do it when javascript on the webpage can?
maybe i misunderstand.
Chinthu 00:09 I want it to be done in the plugin
when I use this m_host->getDOMDocument()->getElement("location")->setProperty("href", url);
it was opening in the same page or tab as the plugin is running
dougma 00:09 well it would.
try calling getDOMWindow()->invoke("open", ....)
which is the same as doing window.open from js
Chinthu 00:09 ohh ok I will try it now
dougma 00:09 i'll leave it to you to figure out the parameters for the open method
Chinthu 00:09 previously I was referring to this http://forum.firebreath.org/topic/112/
dougma 00:09 oh the popup blocker
i remember now
that's one reason to do it on the plugin i suppose
taxilian 13:09 I now have control of Firebreath.com
linearray 13:09 \o/
taxilian 13:09 I had to spend $350 to do it, though
linearray 13:09 ouch
taxilian 13:09 someone was bidding against me; if I hadn't sniped I might have lost it anyway
but they were sniping too
linearray 13:09 that's 175 haircuts
taxilian 13:09 lol
huh. except that I can't actually start using it 'til 10/06
linearray 13:09 Created on: 24-Aug-99
really quite old
kylehuff 14:09 sorry taxilian, I got distracted by a bug in chrome. was there anything else you wanted me to try to do in regards to bug FIREBREATH-116?
FireBreathBot 14:09 FIREBREATH-116: Summary: Call to DllRegisterServer failed
FIREBREATH-116: Assigned To: richard
FIREBREATH-116: Priority: Major, Status: Open, http://jira.firebreath.org/browse/FIREBREATH-116
taxilian 14:09 I am out of ideas for now; I'll have to look at it myself
I finally tracked down a bug I've been working on with my work stuff, so maybe I'll even be able to get to it
kylehuff 14:09 ah, okay. good, cause I never had any ideas to begin with! lol
cool. I had to hunt down a major issue in chrome/chromium beta, no thanks to the devs...
taxilian 14:09 how… exciting...
kylehuff 14:09 not really, I'm just glad it worked out to be a problem with chrome and not my plugin and extension! lol
taxilian 14:09 hehe
kylehuff 14:09 I think someone needs to invent the actual geek card. something you can flash like a badge that indicates "yes, of course I took every possible step to diagnose this myself; don't send me back to the user support channel"
taxilian 14:09 lol
FireBreathBot 14:09 Commit 9c23e34 on master by Richard Bateman: "Updated log4cplus to work w/ 10.4 SDK on mac" http://goo.gl/QIpiU
taxilian 16:09 Chinthu: pastebin me what you've done so far
.pb
FireBreathBot 16:09 When you need to share code, logs, or anything else longer than a couple of lines, use a pastebin. http://fpaste.org, https://pzt.me/, and https://gist.github.com are all good options
Chinthu 16:09 ok I will
one dought if I call this method void NpapiBrowserHost::evaluateJavaScript(const std::string &script)
taxilian 16:09 there are very few cases where that's a good method to call; usually it's better to use the dom
Chinthu 16:09 this will try to exicute the javascript I provide right?
taxilian 16:09 and dom access methods
but yes, it would
Chinthu 16:09 ok great
Chinthu 17:09 hi, I would like to show a little function that I wrote
How do I post code here?
taxilian 17:09 .pb
FireBreathBot 17:09 When you need to share code, logs, or anything else longer than a couple of lines, use a pastebin. http://fpaste.org, https://pzt.me/, and https://gist.github.com are all good options
Chinthu 17:09 https://gist.github.com/4e754dc1ca553d952b88
FireBreathBot 17:09 Commit eb5cdc4 on master by Richard Bateman: "Added SystemHelpers directory helpers for mac" http://goo.gl/NlexW
Commit 5f19cd1 on master by Richard Bateman: "Added System Helpers for windows" http://goo.gl/WCOZh
Commit 9c23e34 on firebreath-1.6 by Richard Bateman: "Updated log4cplus to work w/ 10.4 SDK on mac" http://goo.gl/QIpiU
Commit eb5cdc4 on firebreath-1.6 by Richard Bateman: "Added SystemHelpers directory helpers for mac" http://goo.gl/NlexW
Commit 5f19cd1 on firebreath-1.6 by Richard Bateman: "Added System Helpers for windows" http://goo.gl/WCOZh
taxilian 17:09 Chinthu: what have you done for the IE version/
?
Chinthu 17:09 https://gist.github.com/690c5f224e9c17ecdf03
taxilian 17:09 a few suggestions; use CComBSTR instead of BSTR
and CComVariant instead of VARIANT
Chinthu 17:09 ok
taxilian 17:09 then add a second parameter to the function called "target"
Chinthu 17:09 a string?
taxilian 17:09 yes
Chinthu 17:09 ok
taxilian 17:09 also, don't use const char*, use const std::string&
Chinthu 17:09 ok
taxilian 17:09 !find getURL
FireBreathBot 17:09 Found 1 possible matches. Displaying 1
/^ void getURLCallback(bool success, const FB::HeaderMap& headers,$/ (f) found in src/PluginCore/SimpleStreamHelper.cpp: http://goo.gl/oyk2l
taxilian 17:09 !find getUrl
FireBreathBot 17:09 Found 1 possible matches. Displaying 1
/^std::string BrowserStream::getUrl() const$/ (f) found in src/PluginCore/BrowserStream.cpp: http://goo.gl/somfe
taxilian 17:09 hmm.
!findfile NpapiBrowserHost
FireBreathBot 17:09 Found 4 matching file(s) in the master branch. First 4 are:
src/NpapiCore/NpapiBrowserHost.cpp http://goo.gl/AMLjZ
src/NpapiCore/NpapiBrowserHost.h http://goo.gl/YayhG
src/NpapiCore/Win/NpapiBrowserHostAsyncWin.cpp http://goo.gl/yzoEy
src/NpapiCore/Win/NpapiBrowserHostAsyncWin.h http://goo.gl/Tz4jv
taxilian 17:09 on NPAPI you're going to call this method: https://github.com/firebreath/FireBreath/blob/master/src/NpapiCore/NpapiBrowserHost.cpp#L317
that will do basically the same thing
as the Navigate method on IE
Chinthu 17:09 oh ok
taxilian 17:09 oh, and you need to pass the target into the correct field in the navigate call you're making on IE
Chinthu 17:09 what is target?
taxilian 17:09 http://msdn.microsoft.com/en-us/library/aa752133(v=vs.85).aspx
TargetFrameName
Chinthu 17:09 ohh ok thanks
Chinthu 18:09 how do I convert from std::string to variant?
taxilian 18:09 just assign it
or are you talking about VARIANT? the MS type?
Chinthu 18:09 yes
taxilian 18:09 CComVariant var = stringValue.c_str() should probably work
Chinthu 18:09 It worked thanks :)
FireBreathBot 18:09 Commit 0a73ce1 on master by Richard Bateman: "Fixed build error in unit tests on Mac" http://goo.gl/S0Jbm