IRC Log Viewer » #firebreath » 2011-05-26

IRC Nick Time (GMT-7) Message
FireBreathBot 05:05 JIRA issue http://jira.firebreath.org/browse/FIREBREATH-82 issue created by tomfa
FireBreathBot 07:05 JIRA issue http://jira.firebreath.org/browse/FIREBREATH-83 issue created by kalev
Commit 39de8fd on firebreath-1.5 by Kalev Lember: "Removed garbage at end of an #include directive
Commit 39de8fd on master by Kalev Lember: "Removed garbage at end of an #include directive
dougma 09:05 https://github.com/dougma/FireBreath/blob/master/examples/FBTestPlugin/LeakFinder/StackWalker.cpp
wtf?
how'd that truncated... my repo only
oh... it happened here: https://github.com/firebreath/FireBreath/commit/4ddb52a85b7286a43b1c108f361da48389eeff3d
calili 11:05 Hi, I am working on a Windows plugin, I have extended the FB::PluginWindowWin class and created a CustomWinProc function. The problem is I am not getting any WM_KEYDOWN messages. Is there something I am missing?
kalev 11:05 calili: I faced a similar problem and I solved it by setting up a custom hook with SetWindowsHookEx() in WM_INITDIALOG and then calling IsDialogMessage() in the hook function to process the key presses
no idea if that's a good way to solve it, I'm no good in win32 programming
http://fpaste.org/abrx/
calili 11:05 I think I understand my problem, PluginWindowWin::WinProc handles the WM_KEYDOWN message and never calls CustomWinProc
it seems to me like this line http://classdocs.firebreath.org/_plugin_window_win_8cpp_source.html#l00161 should come before the switch statement
FireBreathBot 13:05 JIRA issue http://jira.firebreath.org/browse/FIREBREATH-83 issue commented by richard "hmm. good point. I apologize; I'm not real familiar with the install stuff, so I'm kinda making t..."
taxilian 13:05 dougma: weird. not sure how that happened or how it didn't seem to affect my copy :-? I'll fix it.
FireBreathBot 14:05 JIRA issue http://jira.firebreath.org/browse/FIREBREATH-84 issue created by arriu
ken__ 15:05 is anyone live?
taxilian 15:05 heh. didn't stay quite long enough :-/
FireBreathBot 15:05 Commit c995ab0 on firebreath-1.5 by Richard Bateman: "FIREBREATH-84: CustomWinProc now called first" http://goo.gl/tVSSw
taxilian 15:05 arriu: fixed
FireBreathBot 15:05 Commit c995ab0 on master by Richard Bateman: "FIREBREATH-84: CustomWinProc now called first" http://goo.gl/tVSSw
arriu 15:05 thanks! this will actually save me a lot of time
FireBreathBot 15:05 JIRA issue http://jira.firebreath.org/browse/FIREBREATH-84 issue resolved by richard "Shows you how often CustomWinProc is used =] Usually people just handle WindowsEvent and do it al..."
taxilian 15:05 yw
there were really two things broken
one is that it should not have done a return unless those events returned true
that would have made it work right there
however, it also makes sense that the CustomWinProc should be checked before anything else
and as it is inlined it shouldn't really be a performance hit to check it when it isn't used, whereas the other way around would be
dougma: not sure how those files got truncated, but it is fixed in the commit I just made
arriu 16:05 I am not sure why you need the "if(SendEvent(&ev)) return true;" in each case? You will only have one message at a time no?
taxilian 16:05 well, moving the CustomWinProc up does somewhat negate that need
but in general, execution should only stop when true is returned or the end of the function is reached
so it's more of a "in principle" thing
=]
if that had been in place and the customwinproc call at the bottom it would have worked
arriu 16:05 alright, well I am just happy that customwinproc can now override the handlers by returning true
:)
taxilian 16:05 now I'm just trying to decide what else should be fixed in 1.5.2
which I need to release
FireBreathBot 16:05 Commit 4bd9f7b on firebreath-1.5 by Richard Bateman: "FIREBREATH-83: Do not by default override CMAKE_INSTALL_PREF..." http://goo.gl/tMtVl
Commit 4bd9f7b on master by Richard Bateman: "FIREBREATH-83: Do not by default override CMAKE_INSTALL_PREF..." http://goo.gl/tMtVl
taxilian 16:05 Kalev: there you are. all fixed
perhaps still not ideal, but should be adequate for now
FireBreathBot 16:05 JIRA issue http://jira.firebreath.org/browse/FIREBREATH-83 issue resolved by richard "Since this was intended specifically for use with FB_RELEASE, I just set it to only override CMAK..."
taxilian 16:05 okay, this is completely ridiculous… FireBreath takes *way* too long to compile, particularly on windows
FireBreathBot 17:05 Commit 0a61b03 on firebreath-1.5 by Richard Bateman: "FIREBREATH-82: Renamed FB::boost_variant::generic to fb_comp..." http://goo.gl/xI1Bl
Commit 0a61b03 on master by Richard Bateman: "FIREBREATH-82: Renamed FB::boost_variant::generic to fb_comp..." http://goo.gl/xI1Bl
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-82 issue resolved by richard "Well, I have renamed that type to fb_compat; it doesn't help you with the boost compiler error, b..."
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-59 issue resolved by richard
sabotaged|wk 17:05 anyone ever tried remote debugging with xcode for a plugin?
trying to figure out why invalidating core animation isn't working on 10.5, chrome, and log4cplus isn't outputting a single thing even when it does on 10.6 for me :|
taxilian 17:05 hmm. to be honest, it has never even occurred to me to try =]
but I wish you the best of luck!
;-)
grr. I hate doing releases
most of it isn't bad, but writing up the release notes is probably the most annoying part of my "job"
sabotaged|wk 18:05 well, i take a little bit of enjoyment in reading them, if that helps
taxilian 18:05 believe it or not, it does help to know that someone finds them useful =]
particularly one of the relatively few that makes an attempt to give back to the project
wow. This partiuclar point release grew way out of hand. It really should be 1.6.0
ahh, well
it isn't
and there are no breaking changes
there are 42 commits in here since 1.5.1
FireBreathBot 18:05 JIRA issue http://jira.firebreath.org/browse/FIREBREATH-55 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-61 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-62 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-67 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-66 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-70 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-73 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-78 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-83 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-82 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-59 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-63 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-64 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-72 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-84 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-53 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-54 issue closed by richard
JIRA issue http://jira.firebreath.org/browse/FIREBREATH-71 issue closed by richard
taxilian 18:05 FireBreath 1.5.2 is officially released! http://npapi.com/x/u4BR
dougma 18:05 bravo!
taxilian 18:05 dougma: I decided to push the windows event fixes and the javascript context fix to 1.6.0
since we still should clarify a few things
dougma 18:05 fair enough
i'm still pondering it. :)
taxilian 18:05 I'm also thinking I need to finally figure out how to make precompiled headers work nicely with cmake, at least on windows… good grief, ScriptingCore took 14 minutes to compile… on my i7
FireBreathBot 19:05 JIRA issue http://jira.firebreath.org/browse/FIREBREATH-85 issue created by richard
taxilian 19:05 if anyone wants to play with it, I have precompiled headers working on ScriptingCore in my personal fork (https://github.com/taxilian/FireBreath). It reduced the build time of ScriptingCore from 14 minutes to 2.5
ciao
FireBreathBot 20:05 JIRA issue http://jira.firebreath.org/browse/FIREBREATH-86 issue created by dougma
dougma 20:05 working on a patch or two
dougma 20:05 taxilian_away: patches in my FB-86 branch
taxilian 20:05 dougma: any interest in doing some tinkering with me on getting build speeds up?
FireBreathBot 21:05 Commit b0ca57c on firebreath-1.5 by dougma: "FIREBREATH-86 getDelayedInvokeDelegate can fail, check for n..." http://goo.gl/XtrHb
Commit b0ca57c on master by dougma: "FIREBREATH-86 getDelayedInvokeDelegate can fail, check for n..." http://goo.gl/XtrHb
kalev 22:05 thanks taxilian
taxilian 22:05 kalev: how well do you know GCC precompiled headers?
kalev 22:05 taxilian: not at all, I've never used them with gcc
taxilian 22:05 fair enough
I have them just about integrated in on windows
which is where we need them the most
cuts the build time at least in half
possibly much more than that
at least on my system
kalev 22:05 excellent
taxilian 22:05 so I'm thinking it would be cool to make them work on linux and mac as well =]
think I found an example, though
so hopefully it's just a matter of finding time
thanks for fixing that weird "bad char after #include" thing… I saw the warning, but hadn't had time to try to figure it out
kalev 23:05 no problem. I'll work on my plugin over the next days and will report back if I find any issues with firebreath.
taxilian 23:05 cool. you finally updating to the latest?
kalev 23:05 Yep. I did an initial port to 1.4 a while back, but didn't finish everything up.
I'll need to do some refactoring to make things nicer on my end with the multi-mime support
taxilian 23:05 I bet =]
there have been a *lot* of other stability fixes since then
and memory leak fixes
kalev 23:05 very good
I need to go afk a bit, thanks again for fixing the CMAKE_INSTALL_PREFIX thing
taxilian 23:05 of course, knowing you you'll find a few more for me =]
no problem. sorry for the inconvenient
inconvenience*
dougma 23:05 taxilian: rebuild FBTestPlugin without your PCH ≈ 6 mins, with ≈ 4 mins
worthwhile :)
taxilian 23:05 not bad. let me commit the rest of the PCH changes =]
just one more minor bug to fix
should improve it even more
I have got to figure out why this computer is so slow, though… it's an i7 and it's taking closer to 20 minutes to build
dougma 23:05 that's vs2010 on an i5 560m
taxilian 23:05 heh. this is vs2010 on an i7-2630QM
8gb ram
which is why I'm a bit confused
dougma 23:05 oh yes debug build.
taxilian 23:05 'cause unless I'm missing something, an i7-2630QM should beat an i5 560m, but it isn't...
hmm. actually, I guess I'm rebuilding the whole project
so I'm getting BasicMediaPlayer as well
that makes a relatively significant difference
dougma 23:05 well it turbos to 3.2 GHz :)
taxilian 23:05 hehe. this si supposed to turbo to 2.8, but I have never seen it do so while compiling
dougma 23:05 also... not sure that debug builds are parallelized by vs
taxilian 23:05 mine seem to be
but it may depend on the configuration
definitely doesn't parallelize as well as xcode
dougma 23:05 and i have an hdd
taxilian 23:05 ssd you mean?
dougma 23:05 no. :)
taxilian 23:05 a hdd? a hard drive?
I have one of those too :-P
dougma 23:05 ok, maybe mine is spinning faster :p
taxilian 23:05 that is quite possible… a lot of things on this hard drive seem to be unusually slow
I may need to start doing some tweaking or osmething… even git is ridiculously slow
dougma: I just pushed changes to give you PCH for the rest of the FB projects
wanna try it and see if it's any faster?
dougma 23:05 sure
taxilian 23:05 in the mean time, I'm going to try to make sure I didn't break anything on mac
so I can put it in master
this is the first 1.6.0 feature
I think it will be a popular one
taxilian 23:05 dougma: have you had a chance to try it yet?
appricot 23:05 Hi thiere,
taxilian 23:05 hello
appricot 23:05 I am trying to write a chrome plugin using firebreath
on win7
I want to access a registry value; I was to do this from the root key HKCU
but fails when on HKLM
i think the win7 UAC is the problem. Any workaround?
taxilian 23:05 when you say "access", do you mean read or write?
appricot 23:05 read only
taxilian 23:05 where in HKLM are you reading?
appricot 23:05 from a subkey