IRC Log Viewer » #firebreath » 2015-09-15

IRC Nick Time (GMT-7) Message
walter 09:09 hi
Hi taxilian
taxilian 09:09 'morning
walter 09:09 question...
taxilian 09:09 answer
answer
walter 09:09 When you added WixSystemToolsExtension to FB at 15'th Apr... --> https://github.com/dblock/msiext
When you added WixSystemToolsExtension to FB at 15'th Apr... --> https://github.com/dblock/msiext
Have you made your own modifications to it?
I just build that - and file templates path is single slash... While in the DLL you added to FB - it's double slash, like: "C:\\Program Files\\Blabla"
That is user for WIX CRX nativehost name.json template
user -> used ;)
taxilian 09:09 yes, I made my own modifications to it
I hacked it to do double slashes
walter 09:09 That slashes, right?
heh ;)
right
I'm missing a feature from msiext .... And I've added it, and now I'm getting single slashes
at least I get this clear now ;)
Could you share your double-slashes DIFF ?
taxilian 09:09 I can look; not certain if I have it still or not, but I'll look =]
we really need to build an example page for the repo so others can help :-/ I haven't had time yet
well, what'd'ya know. I actually did it usefully. https://github.com/gradecam/msiext/commit/30d325e0840f6f6278dd3ecb4bfd5db98167a8bb
I originally tried to make it so you could specify if it should be escaped or not, but never did get it working
I originally tried to make it so you could specify if it should be escaped or not, but never did get it working
walter 10:09 Hehe - you should ;)
https://github.com/dblock/msiext/pull/21#issuecomment-140428222
I'm just applying my change to msiext
I assumed you will not allow my custom WixSystemToolsExtension.dll to be merged to FB - if it's not applied to original project... And it seems you did it that way, haha ;)
thx, I'll use your escape