IRC Log Viewer » #firebreath » 2015-06-24

IRC Nick Time (GMT-7) Message
AndyTather 05:06 Hi taxilian
Thanks for all your work on the FB2.0, I've now got some time to look into using it.
Raised a PR with some changes I've found I needed to create a new plugin and configure host name.
Raised a PR with some changes I've found I needed to create a new plugin and configure host name.
https://github.com/firebreath/FireBreath/pull/154
https://github.com/firebreath/FireBreath/pull/154
I've started an attempt at the ActiveX IE support for FB2.0 but am running into an issue with getting the 'promise' in my AXPromise class
I've started an attempt at the ActiveX IE support for FB2.0 but am running into an issue with getting the 'promise' in my AXPromise class
AndyTather 05:06 I have my deferred and promise objects set to IDispatchAPIPtr, not sure if this okay or not but the init calls
m_axDeferred = host->getPromiseObject();
and that gets the "FireBreathPromise" okay after evaluateJavaScript etc
But the next call to mimic the npapi code m_axPromise = host->getPromiseProperty(m_axDeferred, "promise");
is returning null
or exception for bad variant cast
taxilian 10:06 AndyTather hey sorry I'm here now, but I'm crazy busy today
if you're still around I should be able to chat with you about it a bit, though. it'd be great to get the AX support in
AndyTather 12:06 Hi taxilian, I've push my initial AX changes into my existing PR so we can see,comment and even edit.
taxilian 12:06 cool; I'm crazy busy today, but if you tell me where to look (give me a link) I'll see what I can find to help you
AndyTather 12:06 okay thanks, https://github.com/firebreath/FireBreath/pull/154/files (Towards the end)
okay thanks, https://github.com/firebreath/FireBreath/pull/154/files (Towards the end)
taxilian 12:06 okay, first: you should never change a project name in order to control the output filename
so https://github.com/AndyTather/FireBreath/commit/aab8418ffe6fbecfbd0d0b5ba1b04e50818ffa88 needs to be reverted and done correctly
hmm; I was thinking someone else had already done that correctly. have you double checked the refactor branch to make sure it's not already there?
AndyTather 12:06 Pretty sure I'm up-to-date
Was going to change name in the installer but needed to digitally sign it, I'll take a middle approach
taxilian 12:06 no no
no no
there is a really easy way to do it
there is a really easy way to do it
just change the output filename of the project
just change the output filename of the project
project name stays the same, everything else should Just Work
except it looks like the installer template will need to be fixed slightly
hang on, I'm looking
so someone else seems to have pushed activex changes very recently
https://github.com/firebreath/FireBreath/commit/76a950682942a1838ee8e8da6cc8a747997bfdcb
I haven't tested those; found it when I went to look for the other
so he may have fixed your other problems for you =]
so he may have fixed your other problems for you =]
https://github.com/firebreath/FireBreath/commit/d29ba387ea7db8ae454f25a986d202fc8c76b3c1
that one fixes your firewyrm host executable name
that one fixes your firewyrm host executable name
just set FBSTRING_HostFileName and it will change the output name
just set FBSTRING_HostFileName and it will change the output name
AndyTather ^ most of your changes seem to be already complete...
AndyTather 12:06 I took latest this morning (England time) so will have to catch up it would seem..
I took latest this morning (England time) so will have to catch up it would seem..
taxilian 12:06 the first of those commits is very recent; the second is weeks old, just FYI
kinda ironic; guess two of you were working on it at once. Walter (the author of the other one) has been working with me on it for awhile, though, so it's probably a good fix.
AndyTather 12:06 mmm wonder if my fork isn't updating
taxilian 12:06 it won't update automatically
it won't update automatically
it won't update automatically
you have to pull from the trunk
you have to pull from the trunk
I really appreciate you chipping in =] Hopefully once you're caught up we can get you up to speed to everyone's mutual benefit
AndyTather 12:06 Thanks for your time. Let me resync. :)
walter 14:06 Hi Richard
Hi Richard
taxilian 14:06 hey walter
looks like you got some stuff done recently? =]
looks like you got some stuff done recently? =]
Guest75787 14:06 Yep.. I've done it
Yep.. I've done it
taxilian 14:06 nice. all working?
Guest75787 14:06 I tested all calls in my app... ActiveX is fully working
As for FB I just compiled sample app... But havent really tested it
taxilian 14:06 cool. ... would it be too much to ask you to change the tabs to 4 spaces so that diffs are readable? =]
I can do it myself if I have to, but it makes it hard to read diffs in github because all diff tools interpret tabs as different distances
Guest75787 14:06 Haha.. I'll check it on GIT ;) In my source tree it looked fine ;)
taxilian 14:06 https://github.com/firebreath/FireBreath/commit/76a950682942a1838ee8e8da6cc8a747997bfdcb
of course... because in your source tree you have tabs configured intelligently
that's the reason I use spaces is because it always looks the same
At least from a quick view it looks like you got everything -- I told you it was fairly close. As much as anything, though, I'm happy that someone besides me has looked at all the code =]
Guest75787 14:06 I'll do it. But not right now. We are releasing our code now...
taxilian 14:06 fair 'nuff
thanks
thanks
any thoughts on the architecture?
Guest75787 14:06 No ;) Mainly I was refactoring your Npapi code hehe... I wasnt really innovative hehe
taxilian 14:06 meh, there are a few things I'd do different a second time around, but for the most part it seems reasonable
Guest75787 14:06 It was actually easier then I thought. It took me day and cew hrs
It was actually easier then I thought. It took me day and cew hrs
taxilian 14:06 wasn't beautiful code, but not ugly either
yeah, I ended up having to do some of the lifting just to make it compile =]
so the rest I didn't think would take long, but I just haven't had time to look at it at all
problem is I spent way too much time on it
Guest75787 14:06 I guess now FB 2.0 is ready to release?
Our team is testing our software.. There is no FB related issues so far ;)
Ok.got to go
See you
AndyTather 14:06 Also tested your changes walter, so far so good. Well done!
taxilian, changed my PR to update wix with the FBSTRING_HostFileName variable, but have found this needs to be set in the PluginConfig as a default.
taxilian 14:06 it should be ignored if not provided
AndyTather 15:06 However, if left to be set in the NativeMessageHost\CmakeLists.txt its not available for the wix install script or to be signed.