IRC Log Viewer » #firebreath » 2015-05-04

IRC Nick Time (GMT-7) Message
walter_ 10:05 Hi taxilian
taxilian 10:05 'morning
walter_ 10:05 I've made small change for NativeMessageHost cmake - so that you can define your own name for host process executable
taxilian 10:05 okay
is that all in that same pull request?
walter_ 10:05 no...
taxilian 10:05 is that all in that same pull request?
it's on my list to look at today; I've just been dealing with some build server issues and haven't gotten to it yet
walter_ 10:05 I just did it...
taxilian 10:05 oh, okay
oh, okay
that's fine
walter_ 10:05 Can I push it directly - or would you prefer to review via pull request?
FBSTRING_HostFileName
if it's not defined - then it will be as it was...
taxilian 10:05 that's fine
just push
just push
walter_ 10:05 ok
as for the other pull request - I saw some comments regarding chrome warning for sync ajax call
But it was not yours... Have you review it ?
Changing sync to async shouldn't be difficult... To remove that warning
Changing sync to async shouldn't be difficult... To remove that warning
taxilian 10:05 I haven't yet
I haven't yet
but I will today
walter_ 10:05 ok ;)
taxilian 10:05 I was pretty burned out on Friday, so I worked on some other things
walter_ 10:05 sure, n/p
hehe - nice bot
taxilian 10:05 hmm, that's not going to be enough; you need to also update the manifest file that is installed to have the correct filename, I think. unless that ends up happening automatically somehow?
walter_ 10:05 it changes manifest automatically
taxilian 10:05 I guess I was smarter than I give myself credit for when I wrote that, then =]
walter_ 10:05 I builded my own project + FBTestPlugin