IRC Log Viewer » #firebreath » 2015-04-22

IRC Nick Time (GMT-7) Message
achmad 03:04 hi, i am achmad from indonesia, anyone could help me please how to make plugin browser can read smart card ACOS3??
please give some clues, thank you
walter 03:04 Hi guys
Hi guys
taxilian 10:04 'morning
Guest26014 10:04 Hi taxilian
taxilian 10:04 hello
Guest26014 10:04 hmm - it's walter here... let me rename
walter_ 10:04 hmm
ok
ok
I finally builded the project - and solved the issue with No entry points
taxilian 10:04 huh
that's ... really strange
not complaining, mind you =]
not complaining, mind you =]
walter_ 10:04 The issue was in "cmake/CommonPluginConfig.cmake" file - related to changes of creating the macros firebreath_configure_templates, firebreath_generate_templates
The issue was in "cmake/CommonPluginConfig.cmake" file - related to changes of creating the macros firebreath_configure_templates, firebreath_generate_templates
I have no experience with Cmake btw.
anyway
taxilian 10:04 what did you have to change?
walter_ 10:04 few lines after this macros - there is pieace of a code that looks for files in "gen" --> file (GLOB FB_PLUGIN_GENERATED_SOURCES --- and --- file (GLOB FB_PLUGIN_GENERATED_WIN_SOURCES
few lines after this macros - there is pieace of a code that looks for files in "gen" --> file (GLOB FB_PLUGIN_GENERATED_SOURCES --- and --- file (GLOB FB_PLUGIN_GENERATED_WIN_SOURCES
in my case - when cmake was doing it - the "gen" folder was not created yet
I tried to grep - how firebreath_generate_templates is called - but I couldn't find it....
so my fix was to add this line: firebreath_generate_templates(false) ---> just after macros definition
at line 164
taxilian 10:04 hmm; that definitely should not be needed. I wonder if there is a problem with the cmake files in EchoTestPlugin; I thought I'd tested it, but maybe I didn't complete the test and forgot
walter_ 10:04 Are you clear what happened?
Are you clear what happened?
taxilian 10:04 somewhat; clear enough to know that it shouldn't have been possible
so there is something wrong, probably with the project
walter_ 10:04 I tried both EchoTestPlugin and FBTestPlugin
same results
same results
taxilian 10:04 really? that's weird. what version of cmake are you using?
really? that's weird. what version of cmake are you using?
walter_ 10:04 latest one - 3.2.2
taxilian 10:04 hmm. I'm on 3.2.1, but I wouldn't think that'd make that kind of difference
walter_ 11:04 The way I found it - is that I was echoing (message) things all over the CommonPluginConfig.cmake file....
taxilian 11:04 firebreath_generate_templates is called from the CMakeLists.txt file in the plugin project dir
firebreath_generate_templates is called from the CMakeLists.txt file in the plugin project dir
walter_ 11:04 When this pieace of a code runes:
taxilian 11:04 examples/EchoTestPlugin/CMakeLists.txt line 41
walter_ 11:04 thats true
"gen" folder gets generated
but I guess - that happens after "CommonPluginConfig.cmake" is done
and "gen" folder files are required by that file
file (GLOB FB_PLUGIN_GENERATED_SOURCES
${FB_TEMPLATE_DEST_DIR}/[^.]*
${FB_TEMPLATE_DEST_DIR}/global/[^.]*
)
when this executes - "gen" is not generated yet
taxilian 11:04 hmm. yes, that is definitely an issue
hmm. yes, that is definitely an issue
and the weirdest thing is that I can't figure out why it's been working for me, unless I've always run it twice and didn't realize it
and the weirdest thing is that I can't figure out why it's been working for me, unless I've always run it twice and didn't realize it
walter_ 11:04 kylehuff - also mentioned that regsvr32 sometimes works for him - sometimes it doesn't...
And I guess this was the issue...
taxilian 11:04 for now, just run the prep script twice and I'll try to fix that. I suspect that I'll end up moving the generate_templates command into commonpluginconfig.cmake, but I need to make sure I don't cause any other issues with the change
it could well be, though I thought he'd indicated a different error message
it could well be, though I thought he'd indicated a different error message
walter_ 11:04 well... In Firebreath 1.7 - in the place where you define macros - you just generate those templates there....
well... In Firebreath 1.7 - in the place where you define macros - you just generate those templates there....
And when I runned those macros right away after definitions - it's fine...
And when I runned those macros right away after definitions - it's fine...
taxilian 11:04 but you didn't remove the other one
but you didn't remove the other one
and you did prevent it from allowing overrides
walter_ 11:04 right
taxilian 11:04 I think it'll probably work, but I want to make sure I consider the implications. the cmake stuff is a bit more complex than I wish it was
cmake is really a terrible system. it's almost as bad as all the other options
walter_ 11:04 ok, thats 1'st bug I found
ok, thats 1'st bug I found
in src/NativeMessageHost/Win/PluginLoaderWin.cpp --> getPluginList() - there is another bug
it's reading only 1'st registry key from SOFTWARE\\MozillaPlugins
if there is more keys - it's reading first one <x> times
You need to reset lpcName - before calling RegEnumKeyEx
taxilian 11:04 ...? again, works on mine....
but can you submit a pull request?
but can you submit a pull request?
walter_ 11:04 Adding lpcName = MAX_KEY_LENGTH; // reset lpcName buffer size --------> inside while() - fix the issue
if you had only 1 plugin there - it works...
In my case it was 3'rd ;)
taxilian 11:04 I stepped through it looking at all of the plugins
I stepped through it looking at all of the plugins
possible I somehow broke it later, though =]
possible I somehow broke it later, though =]
walter_ 11:04 not sure - if I can push the fix for it myself?
taxilian 11:04 sorry, I'm back. if you fork it on github you can push the fix there and then submit a pull request (or just give me a link) and I can pull it that way
this is kinda weird; I think I had that line in there before and it's not there now
not sure how that happened
not sure how that happened
actually I know the line was there
actually I know the line was there
so that fix I'll just push
so that fix I'll just push
I probably didn't see because it will actually work if the next plugins found have a shorter name
walter_ 11:04 ok - I see you already added the fix ;)
taxilian 11:04 yep