|IRC Nick||Time (GMT-7)||Message|
|chardy||10:07||Hi @taxilian - for FB261, I thought it better to go with boost::call_once to handle the static init. Would you mind taking a look at this please? https://github.com/chrishardy99/FireBreath/compare/firebreath:master...master|
|taxilian||10:07||oh, yeah, I'd forgotten about that one… that should work well, I woiuld expect
I think that should work, but do have one concern
will boost::call_once serialize the calls, or just make sure that the second one won't call it if it's been called?
because if your code continues while tdm is only half built you could run into issues...
|chardy||10:07||It's synchronized so that the 2nd man in waits until the first call_once has completed|
that's fine, then
(it's been awhile since I looked at call_once; as I said, I totally forgot about it)
|chardy||10:07||thanks, I'll create the pull request|
|taxilian||10:07||cool. you have tested this in all browsers?|
|chardy||10:07||Ah, no. Only IE.
Oh, and Chrome
I mean FF
Where else should I test it?
|chardy||11:07||okay, tested on PC: IE11, Chrome, FF; Mac: Safari, FF, Chrome|
|taxilian||12:07||if you could find a way to test at least on IE9 that would make me feel better
IE8 would be nice, but I dont' really care that much
|chardy||12:07||I'll see what I can do :)
I'll see what I can do :)
is firebreath fully 100% free for commercial projects?
|chardy||16:07||@taxilian: FB261 fix looks good on IE9 and IE8|
|chardy||16:07||And thank YOU, taxilian :)|