IRC Log Viewer » #firebreath » 2014-03-07

IRC Nick Time (GMT-7) Message
taxilian 09:03 rcohn theoretically, yes
rcohn theoretically, yes
dougma 16:03 hi taxilian, have you had time to look at the fb-179 changes?
taxilian 16:03 I've been a bit distracted, let me look
I've been a bit distracted, let me look
was it in a pull request or branch somewhere?
dougma 16:03 it's a branch. i'll just get the compare link for you
https://github.com/dougma/FireBreath/compare/FB-179
the remaining work is to make it conditionally compile so that people without the right sdk, or people who just don't want surface rendering, can opt out.
taxilian 16:03 tell me what we're solving here?
dougma 16:03 it lets you render to direct3d surfaces
taxilian 16:03 ooh, nice.
dougma 16:03 napapi and activex on windows
taxilian 16:03 hmm. one request would be to normalize the tabs
you have half tabs and half spaces
dougma 16:03 normalise to spaces?
taxilian 16:03 makes it hard to read in source control editor
yeah, tab -> 4 spaces
that's what the rest of the tree uses
dougma 16:03 yeah i've been fixing them as i see them. :)
taxilian 16:03 there is even a script in there (unix) that will fxi it
there is even a script in there (unix) that will fxi it
fix it
fix it
hmm. this looks like you have to have an html param tag to set it to async?
dougma 16:03 no
taxilian 16:03 what is https://github.com/dougma/FireBreath/compare/FB-179#diff-3a862e0c9537881b94a98a7cb74a9c4cR345 ?
dougma 16:03 oh yes, the same param as Mac uses to select drawing model
oh yes, the same param as Mac uses to select drawing model
taxilian 16:03 actually mac just uses that to force a drawing model
otherwise it picks it based on what seems best
dougma 16:03 the user can override getParam if they don't want to have to provide the param in the html
taxilian 16:03 I'd really rather not make that a requirement to use this
dougma 16:03 not sure how else to select the drawing mode
taxilian 16:03 what we probably should do is come up with some way that the plugincore obj can be called with "these are the options, choose one" or some such
what we probably should do is come up with some way that the plugincore obj can be called with "these are the options, choose one" or some such
I'm not sure if that's easy to wire in, though
bascially I would expect that if the plugin supports d3d async then that would be the correct mode on windows
dougma 16:03 it's an entirely different rendering approach
taxilian 16:03 basically that's how it works on Mac; you set which models you support, and it picks the best one that both the plugin and the browser support
basically that's how it works on Mac; you set which models you support, and it picks the best one that both the plugin and the browser support
dougma 16:03 it's not compatible with gdi
it's not compatible with gdi
taxilian 16:03 I know
but nor are coreanimation and coregraphics at all compatible
dougma 16:03 ok.
taxilian 16:03 so the most consistent (though still maybe not the best) option would be to have it ask the plugin if it supports d3d, and if it does and the browser does then use that
so the most consistent (though still maybe not the best) option would be to have it ask the plugin if it supports d3d, and if it does and the browser does then use that
else fall back to the next best option
dougma 16:03 i did at one stage have drawingmodel as a list of preferred models
so firebreath would provide the first one it could
taxilian 16:03 that's probably the easiest and most consistent option
then the getParam would be to override the option
the auto selection, I mean
the auto selection, I mean
dougma 16:03 well i had the list coming from getParam
taxilian 16:03 default should never rely on someone to put in parameters from the page
dougma 16:03 sure
sure
taxilian 16:03 in order of priorities to me, that's about the top on all of these =]
and getParam is designed to be a "get the value from the page" method
shouldn't be overridden for configuration
dougma 16:03 ok it's a bit obtuse i agree. :)
taxilian 16:03 there are several things I'd probably do differently if I went back and changed it, but I figure the most important thing at this point is consistency
it's not worth changing the core pattern there and breaking backwards compatibility
dougma 16:03 no... i've resisted changing other things in the name of backwards compat too.
no... i've resisted changing other things in the name of backwards compat too.
taxilian 17:03 oh, good =]
this is awesome, though
dougma 17:03 it works.
which is nice. :)
which is nice. :)
i want to make a fancier d3d example
i want to make a fancier d3d example
but d3d is awkward with lots of dependencies so it'll be a separate plugin
(not in fbtestplugin)
taxilian 17:03 that sounds like a good idea to me
dougma 18:03 thanks for the feedback. i'll make the changes and get back to you. :)